Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribute precompiled framework #5

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Oct 25, 2024

Summary

We want to start distributing Amplitude-Swift as a precompiled package, which means compiling it with BUILD_LIBRARY_FOR_DISTRIBUTION (this enables compatibility with future swift compilers, which is why we still target the oldest supported version on macos-latest) and packaging it as an XCFramework. Most build systems will also want dependencies to conform to this as well.

This PR adds a script to create the xcframework, then add it as an artifact to our releases. Initially, this will only be picked up by Carthage builds. Once I can test with an actual release, I'll add an other option for SPM to just use the precompiled version.

Successful release dry run: https://github.com/amplitude/analytics-connector-ios/actions/runs/11512316382

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@crleona crleona requested a review from bgiori October 25, 2024 05:50
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crleona crleona merged commit e67d034 into main Oct 29, 2024
4 checks passed
@crleona crleona deleted the precompiled_framework branch October 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants